MigCluster : Use generateName to create unique secrets #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… MigRepository secret
pranavgaikwad
commented
Mar 20, 2020
| @@ -304,7 +327,7 @@ function* updateClusterRequest(action) { | |||
|
|
|||
| // Pushing a request fn to delay the call until its yielded in a batch at same time | |||
| updatePromises.push(() => client.patch( | |||
| secretResource, clusterValues.name, newTokenSecret)); | |||
| secretResource, currentCluster.spec.serviceAccountSecretRef.name, newTokenSecret)); | |||
There was a problem hiding this comment.
Here I am assuming that Cluster name is not changeable from UI
ibolton336
requested changes
Mar 20, 2020
|
@ibolton336 added a fix to address the problem you saw. safe guarded the case when - associated Secret does not exist and we try to delete a cluster. |
Add network error check for alert modal
ibolton336
requested changes
Mar 23, 2020
ibolton336
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #396
Proposed Changes :
[1] Creating new MigCluster
generateNameinstead ofnamein tokenSecret of MigCluster. We also introduce two new labels on the Secret :createdForResourceType,createdForResource. This makes it easier to find a secret associated with a cluster.[2] Deleting MigCluster
[3] Editing MigCluster