Refactor string normalization function and test it.

[HarikrishnanBalagopal]

Description

This package normalizes certain strings in the intermediate representation.
It strips any whitespace and quotations/commas from each container's environment variables.

Two things need to be done:

1. The package is not written in the most idiomatic way.
2. The package needs unit tests.

Some examples of code that needs to be refactored:

• This should be for _, scObj := range ir.Services {
  https://github.com/konveyor/move2kube/blob/master/internal/optimizer/normalizecharactersoptimizer.go#L34-L35
• This should use TrimSpace https://golang.org/pkg/strings/#TrimSpace
  https://github.com/konveyor/move2kube/blob/master/internal/optimizer/normalizecharactersoptimizer.go#L40-L41
• This function shouldn't return an error since it isn't supposed to fail:
  https://github.com/konveyor/move2kube/blob/master/internal/optimizer/normalizecharactersoptimizer.go#L60-L64

How to get started

For this issue you should start with some simple tests that creates simple IR objects and calls the function on them.
Next step would be to make slight changes to the IR objects and create a separate subtest for each scenario.
Some scenarios that are good to test:

• Function called on an IR with no services.
• An IR containing services that have no containers.
• An IR containing services and containers but the containers have no environment variables.
• An IR containing services and containers and all the environment variables are valid.
• An IR containing services and containers and some of the environment variables are invalid (containing spaces and quotes).
• An IR containing services and containers and some of the environment variables are invalid but their names contain the string affinity.

How to add unit tests

Some guidelines:

• Look at the other tests in the package/project and write similar tests.
• Use subtests to test different paths through the function.
• Don't worry about testing every single path through the function. Focus on common use cases and failure modes.

Some helpful resources on how to write unit tests in Go:

• https://blog.golang.org/subtests
• https://youtu.be/hVFEV-ieeew

Code to be tested

move2kube/internal/optimizer/normalizecharactersoptimizer.go

Lines 32 to 64 in c9b5d0f

	func (po normalizeCharacterOptimizer) optimize(ir irtypes.IR) (irtypes.IR, error) {
	//TODO: Make this generic to ensure all fields have valid names
	for k := range ir.Services {
	scObj := ir.Services[k]
	for _, serviceContainer := range scObj.Containers {
	var tmpEnvArray []corev1.EnvVar
	for _, env := range serviceContainer.Env {
	if !strings.Contains(env.Name, "affinity") {
	env.Name = strings.Trim(env.Name, "\t \n")
	env.Value = strings.Trim(env.Value, "\t \n")
	tmpString, err := stripQuotation(env.Name)
	if err == nil {
	env.Name = tmpString
	}
	tmpString, err = stripQuotation(env.Value)
	if err == nil {
	env.Value = tmpString
	}
	tmpEnvArray = append(tmpEnvArray, env)
	}
	}
	serviceContainer.Env = tmpEnvArray
	}
	ir.Services[k] = scObj
	}
	return ir, nil
	}
	func stripQuotation(inputString string) (string, error) {
	regex := regexp.MustCompile(`^[',"](.*)[',"]$`)
	return regex.ReplaceAllString(inputString, `$1`), nil
	}

[suramrit]

@HarikrishnanBalagopal Would like to get working on this!
Thanks for the great head start and background on the issue! 🚀

[ShajithaMohammed]

@HarikrishnanBalagopal @ashokponkumar @suramrit Actually I have addressed this issue and ready to raise a PR,Forgot to sign-up. Apologies.
Let me know if I can go ahead and raise a PR.

[ashokponkumar]

@ShajithaMohammed You can raise a PR and together with @suramrit based on his changes, we can together refine it and merge.