Consider scc-SA mappings which map to all namespace SAs #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dymurray
approved these changes
Feb 26, 2020
The scc "users" element includes mappings for service accounts in two different forms: system:serviceaccount:<namespace> system:serviceaccount:<namespace>:<serviceaccount> Without this commit, the plugin only works correctly for the second type. It fails for the first because it assumes that the fourth element will always be present if the third is there. In the first case, the scc would map to *all* service accounts in the namespace, so this commit checks for the fourth element and handles it properly when it is not found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scc "users" element includes mappings for service accounts
in two different forms:
system:serviceaccount:
system:serviceaccount::
Without this commit, the plugin only works correctly for the second
type. It fails for the first because it assumes that the fourth
element will always be present if the third is there. In the
first case, the scc would map to all service accounts in the
namespace, so this commit checks for the fourth element and handles
it properly when it is not found.