For imagestreamtags referencing ImageStreamImage, copy by tag #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ImageStreamTags, when the tag references something external (docker image, ImageStreamTag, or ImageStreamImage), we were copying any internal images without tag and relying on the ImageStreamTag restore to recreate the tags. This exposes us to an upstream Velero issue where a prior ImageStreamTag restore (the one which should have created the tag or image which this one references) completes but the resource isn't yet available, so the ImageStreamTag resource fails to restore. This commit modifies the behavior for local-namespace ImageStreamImage references -- copying these by tag into the registry rather than restoring via the ImageStreamTag resource. The race condition still potentially exists for references to other namespaces included in the backup or references by ImageStreamTag.
dymurray
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ImageStreamTags, when the tag references something external
(docker image, ImageStreamTag, or ImageStreamImage), we were
copying any internal images without tag and relying on the
ImageStreamTag restore to recreate the tags. This exposes us to
an upstream Velero issue where a prior ImageStreamTag restore
(the one which should have created the tag or image which this
one references) completes but the resource isn't yet available,
so the ImageStreamTag resource fails to restore.
This commit modifies the behavior for local-namespace ImageStreamImage
references -- copying these by tag into the registry rather than
restoring via the ImageStreamTag resource. The race condition still
potentially exists for references to other namespaces included in the backup
or references by ImageStreamTag.