Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TACKLE-355]: [Tackle - 1.2 - regression] Control entities name unique constraint validation #203

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

carlosthe19916
Copy link
Contributor

@carlosthe19916 carlosthe19916 commented Jan 19, 2022

https://issues.redhat.com/browse/TACKLE-355

  • Added custom CustomRestDataPanacheExceptionMapper to override the default Mapper coming from Quarkus.
  • Enhanced the ServicesParameterizedTest.java to verify the DB duplicate error message is the expected one

I've locally created a container image based on this PR quay.io/carlosthe19916/tackle-controls:TACKLE-355 and you can use it to test it if required. Although you can always create your own container image executing:

mvn -U -B package --file pom.xml -Pcontainer-image -Pnative -DskipTests \
  -Dquarkus.container-image.push=true \
  -Dquarkus.container-image.group=YOUR_QUAY_USERNAME \
  -Dquarkus.container-image.additional-tags=TACKLE-355 \
  -Dquarkus.container-image.registry=quay.io \
  -Dquarkus.container-image.username=YOUR_QUAY_USERNAME \
  -Dquarkus.container-image.password=YOUR_QUAY_PASSWORD

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #203 (9839fa5) into main (8d0abe0) will decrease coverage by 2.83%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #203      +/-   ##
============================================
- Coverage     98.36%   95.52%   -2.84%     
- Complexity       73       78       +5     
============================================
  Files            15       16       +1     
  Lines           122      134      +12     
  Branches          9       11       +2     
============================================
+ Hits            120      128       +8     
- Misses            1        3       +2     
- Partials          1        3       +2     
Impacted Files Coverage Δ
...ceptions/CustomRestDataPanacheExceptionMapper.java 57.14% <57.14%> (ø)
...kle/controls/resources/StakeholderAddResource.java 100.00% <100.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d0abe0...9839fa5. Read the comment docs.

Copy link

@jmle jmle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jmle jmle merged commit 5590dce into migtools:main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants