Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TACKLE-243]-Selecting all applications and then selecting 10 applications in adoption candidate distribution report does not work #198

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

carlosthe19916
Copy link
Contributor

https://issues.redhat.com/browse/TACKLE-243

New behavior description with an example:

  • There are 100 elements in the table
  • The user is located on the 5th page; so the table shows the elements 50,51,52,...59
  • The user clicks on Select page (10 elements)
  • The Table will select only the elements of the current page (10 elements). It means, the selected rows will be only 50,51,52,...59

Screenshot from 2021-06-22 15-14-52

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #198 (1c0bead) into main (deb6d96) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage   30.70%   30.71%           
=======================================
  Files         172      172           
  Lines        3775     3774    -1     
  Branches      729      729           
=======================================
  Hits         1159     1159           
+ Misses       2615     2614    -1     
  Partials        1        1           
Flag Coverage Δ
unitests 30.71% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ption-candidate-table/adoption-candidate-table.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deb6d96...1c0bead. Read the comment docs.

@PhilipCattanach
Copy link

I am happy this is working as expected. Thanks!

@PhilipCattanach PhilipCattanach merged commit 15b26d5 into migtools:main Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants