Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TACKLE-241]-Reports : Identified Risk report shows wrong filter #207

Merged
merged 2 commits into from
Jun 25, 2021

Conversation

carlosthe19916
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #207 (783b177) into main (c8bc97e) will increase coverage by 2.67%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
+ Coverage   59.67%   62.35%   +2.67%     
==========================================
  Files         172      172              
  Lines        3787     3817      +30     
  Branches      731      741      +10     
==========================================
+ Hits         2260     2380     +120     
+ Misses       1525     1435      -90     
  Partials        2        2              
Flag Coverage Δ
e2etests 62.99% <ø> (-0.45%) ⬇️
unitests 30.36% <0.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../identified-risks-table/identified-risks-table.tsx 0.00% <0.00%> (ø)
src/api/rest.tsx 75.60% <0.00%> (+0.79%) ⬆️
...mponents/questionnaire-form/questionnaire-form.tsx 4.76% <0.00%> (+4.76%) ⬆️
...ents/custom-wizard-footer/custom-wizard-footer.tsx 94.73% <0.00%> (+5.26%) ⬆️
...rm/multi-input-selection/multi-input-selection.tsx 9.09% <0.00%> (+9.09%) ⬆️
...controls/stakeholder-groups/stakeholder-groups.tsx 71.42% <0.00%> (+9.18%) ⬆️
src/pages/controls/tags/tags.tsx 74.21% <0.00%> (+12.50%) ⬆️
...s/controls/tags/components/tag-table/tag-table.tsx 100.00% <0.00%> (+16.66%) ⬆️
...omponents/stakeholders-form/stakeholder-select.tsx 30.43% <0.00%> (+30.43%) ⬆️
...nts/stakeholders-form/stakeholder-group-select.tsx 30.43% <0.00%> (+30.43%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8bc97e...783b177. Read the comment docs.

@PhilipCattanach
Copy link

Successfully tested in PSI and the filters are working consistently with the Application Inventory filters.

@PhilipCattanach PhilipCattanach merged commit 443f963 into migtools:main Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants