Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the description of GTEST_CREATE_SHARED_LIBRARY in README. #315

Closed
GoogleCodeExporter opened this issue Aug 7, 2015 · 7 comments
Closed

Comments

@GoogleCodeExporter
Copy link

The wording in the README file on 
GTEST_CREATE_SGHARED_LIBRARY/GTEST_LINKED_AS_SHARED_LIBRARY macros implies they 
are also used on non-Windows platforms. We should fix that.

Original issue reported on code.google.com by vladlosev on 23 Sep 2010 at 7:27

@GoogleCodeExporter
Copy link
Author

Original comment by w...@google.com on 27 Sep 2010 at 6:20

  • Changed title: Correct the description of GTEST_CREATE_SHARED_LIBRARY in README.
  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect

@GoogleCodeExporter
Copy link
Author

The intention *is* that these macros are used on any platform that supports 
shared libraries.  Are they not working on non-Windows?

Original comment by w...@google.com on 27 Sep 2010 at 6:26

@GoogleCodeExporter
Copy link
Author

They are coded only for Windows.

Original comment by vladlosev on 27 Sep 2010 at 7:24

@GoogleCodeExporter
Copy link
Author

That does not matter.  We want people to *always* use these macros when using 
gtest as a shared library, even though they are not technically required today 
when using GCC.  The fact that you don't need them for GCC is an implementation 
artifact - it may well change in a future release.

I'll clarify this in README.

Original comment by w...@google.com on 27 Sep 2010 at 8:53

@GoogleCodeExporter
Copy link
Author

Original comment by w...@google.com on 27 Sep 2010 at 8:53

@GoogleCodeExporter
Copy link
Author

Original comment by w...@google.com on 28 Sep 2010 at 4:50

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Fixed in r488.

Original comment by w...@google.com on 28 Sep 2010 at 9:29

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant