Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces in buttons need to be dealt with #32

Closed
keatonlao opened this issue Feb 26, 2023 · 3 comments
Closed

Spaces in buttons need to be dealt with #32

keatonlao opened this issue Feb 26, 2023 · 3 comments

Comments

@keatonlao
Copy link

$:/plugins/kookma/commander/buttons/pagecontrol

Here are my modifications:

\whitespace trim
\define commander-button(class)
\whitespace trim
<$button to="$:/Commander" tooltip={{$:/language/Buttons/Commander/Hint}} aria-label={{$:/language/Buttons/Commander/Caption}} class="""$(tv-config-toolbar-class)$ $class$""">
<$list filter="[<tv-config-toolbar-icons>match[yes]]">
{{$:/plugins/kookma/commander/images/commander.svg}}
</$list>
<$list filter="[<tv-config-toolbar-text>match[yes]]">
<span class="tc-btn-text"><$text text={{$:/language/Buttons/Commander/Caption}}/></span>
</$list>
</$button>
\end

<$list filter="[list[$:/StoryList]] +[field:title[$:/Commander]]" emptyMessage=<<commander-button>>>
<<commander-button "tc-selected">>
</$list>

OCD, can't accept one more or less space

@kookma
Copy link
Owner

kookma commented Feb 27, 2023

Hi @keatonlao
I did not follow what is the issue. The commander button is based on $:/core/ui/Buttons/control-panel
Did you see extra space in page control?

@keatonlao
Copy link
Author

You can see it in $:/core/ui/ControlPanel/Toolbars/PageControls.

If you don't show the page button, the same can be seen in the More drop-down menu: $:/core/ui/Buttons/more-page-actions.

I found that the $:/plugins/kookma/utility/ui/Buttons/ViewFields button also has space problems.

To check page buttons for space problems, I usually check these items:

  • $:/core/ui/SideBarSegments/page-controls
  • $:/core/ui/SideBar/Tools
  • $:/core/ui/ControlPanel/Toolbars/PageControls
  • $:/core/ui/Buttons/more-page-actions

After hiding the buttons, repeat the check again

Thanks @kookma

@kookma
Copy link
Owner

kookma commented Mar 8, 2023

Ah I got it thank you!
A fix is coming in few minutes.

@kookma kookma closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants