Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors should be normalized and in the requested MIME-Type format #32

Closed
ajturner opened this issue Jun 10, 2015 · 4 comments
Closed

Errors should be normalized and in the requested MIME-Type format #32

ajturner opened this issue Jun 10, 2015 · 4 comments
Assignees
@chelm
Labels
bug

Comments

@ajturner
Copy link
Contributor

Requesting

http://firstmap.delaware.opendata.arcgis.com/datasets/5d1d1faf58344909b36b14b6be2f0748_0.csv?url_only=true

starts with {"status":"processing","processing_time":13840.153,"count":0}, and then after some error responds with plain text Could not create export, missing data

/cc @dmfenton
@ajturner ajturner added the bug label Jun 10, 2015
@dmfenton
Copy link
Contributor

We should take this as an opportunity to refactor status messages throughout all of Koop. Not just any one provider.

@jwieringa
Copy link

All error messages being returned in JSON is not a bug, it is done on purpose. We can discuss why and the problems we solved by doing this.

@ajturner
Copy link
Contributor Author

@jwieringa you mean that "All error messages not being returned in JSON is not a bug"?

@dmfenton
Copy link
Contributor

dmfenton commented Sep 1, 2015

This is done. If we find cases where I missed something we can log new bugs.

@dmfenton dmfenton closed this as completed Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chelm chelm

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ajturner @jwieringa @chelm @dmfenton