Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate feature OBJECTID as numeric hash of a specific field #966

Open
rgwozdz opened this issue Apr 9, 2024 · 0 comments
Open

Generate feature OBJECTID as numeric hash of a specific field #966

rgwozdz opened this issue Apr 9, 2024 · 0 comments
Labels
enhancement LOE: high Level Of Effort: high performance Improve performance of an existing feature

Comments

@rgwozdz
Copy link
Member

rgwozdz commented Apr 9, 2024

For datasets that have no unique identifier with property name OBJECTID or no feature ID field targeted by metadata.idField, Koop auto-generates an integer OBJECTID by hashing the entire feature. While this is useful for the edge-case in which a feature has no unique identifier, it's potentially problematic because:

  • it may be costly to hash the whole feature; consider a feature with large number of attributes or complex geometry.
  • the feature may change with edits, and when it does, the numeric hash with change

My assumption is that most datasets will have some unique-identifier, though it is often the case that such identifiers are NOT integers. It is increasingly common for IDs to be strings. Provider developers can point idField to a string property, but some ArcGIS clients will not be able to properly consume such services (the JS API appears to work, but ArcGIS Pro does not). It would therefore be nice if a developer could direct the hasher to one specific property to hash into an integer.

As an add-on here, it seems like ArcGIS clients now support 64-bit integer IDs, so we should hash to that datatype as we move forward.

@rgwozdz rgwozdz added enhancement performance Improve performance of an existing feature LOE: high Level Of Effort: high labels Apr 9, 2024
@rgwozdz rgwozdz changed the title Generate feature OBJECTID as numeric has of a specific field Generate feature OBJECTID as numeric hash of a specific field Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement LOE: high Level Of Effort: high performance Improve performance of an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant