Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI minor changes rollup #35

Closed
28 tasks done
rcoup opened this issue Nov 23, 2021 · 5 comments
Closed
28 tasks done

UI minor changes rollup #35

rcoup opened this issue Nov 23, 2021 · 5 comments
Assignees

Comments

@rcoup
Copy link
Member

rcoup commented Nov 23, 2021

Minor UI changes (mostly wording) rollup issue

  • Working tree → Working copy everywhere

CleanShot 2021-11-23 at 10 57 33

  • heading → “Your Kart installation location is not configured:”
  • stray "."

CleanShot 2021-11-23 at 10 52 40

  • pane titlebar → "Kart Repositories"

  • hint text → "Tip: right-click on items for available actions"

  • remove logo/heading (ideally move logo to pane title not a thing)

  • add a space between repo title & branch name

  • can we collapse the repository path in the middle when the panel isn't wide enough and the repo doesn't have a title set? I think Qt supports this via elidedText. ie:

    /Users/rcoup/code/kart-foss4g-2021/workshop/first [mybranch]  # now
    ~/code/kart-foss4g-2021/workshop/first [mybranch]             # use ~ for os.path.expanduser('~') prefix
    ~/code/.../workshop/first [mybranch]                          # collapse in the middle
    

CleanShot 2021-11-23 at 11 25 21

  • Remove this repository: icon → minus-circle-outline
  • Show log: icon → history
  • Show working tree changes: icon → compare
  • Discard working tree changes: icon → undo
  • Commit working tree changes: icon → content-save-outline
  • Switch branch: icon → swap-horizontal
  • Apply patch: icon → file-import-outline
  • Menu order/wording
    • -break-
    • Show log...
    • Show working copy changes...
    • Discard working copy changes
    • Commit working copy changes...
    • Switch branch...
    • Merge into {current-branch}...
    • -break-
    • Pull...
    • Push...
    • -break-
    • Import layer to repository...
    • Apply patch...
    • -break-
    • Refresh
    • Properties...
    • Remove this repository

CleanShot 2021-11-23 at 12 02 17

  • Matching icon and wording changes from the repository context menu
  • Menu ordering:
    • Add to QGIS project
    • -break-
    • Show log...
    • Show working copy changes for dataset...
    • Discard working copy changes for dataset
    • Commit working copy changes for dataset...
    • -break-
    • Remove from repository

Diff Viewer dialog

  • Restore old version
  • Restore new version
  • Don't show restore new version when displaying working-tree changes
  • Project layers should be the default for "additional layers"
  • Map extent needs some padding so vertices don't end up drawn on the edges of the map
  • Swipe cursor should change from hand to resize when the mouse hovers over the black line
  • Scrolling to zoom seems really rough nevermind, is my machine
  • [status message] Working copy has been updated.

Layer context menu

  • Can we add the Kart icon to make it stand out a bit in the menu?
  • Wording/icons need to match the other menus
@rcoup rcoup changed the title UI text changes rollup UI minor changes rollup Nov 23, 2021
@volaya
Copy link
Contributor

volaya commented Nov 23, 2021

The QGIS API does not allow adding icons to the group entry in the layer context menu

@rcoup
Copy link
Member Author

rcoup commented Dec 14, 2021

Looking good! A few more

  • Can we auto-expand Repositories in the explorer pane if we have some?

  • And ideally auto-expand Datasets when you expand a repository

  • I think we should drop the entire logo & heading from here... it still looks awkward to me.

    CleanShot 2021-12-14 at 11 57 04

@volaya
Copy link
Contributor

volaya commented Dec 14, 2021

We can have the content autoexpand. The reason for expanding it on demand is that populating the tree requires calling kart, so if you have several repos, that would mean several calls to get metadata information (layers, current branch, etc) for each of them, which can take time.

Maybe we can have that as an option, so the user can select what to do. For users with a couple of repos, it is a good thing, but if there are many, users migh want to disable that behaviour

I will take away the logo and heading, no problem.

@rcoup
Copy link
Member Author

rcoup commented Dec 14, 2021

The reason for expanding it on demand is that populating the tree requires calling kart, so if you have several repos, that would mean several calls to get metadata information (layers, current branch, etc) for each of them, which can take time.

Good point.

Maybe we can have that as an option, so the user can select what to do. For users with a couple of repos, it is a good thing, but if there are many, users migh want to disable that behaviour

I'm not a huge fan of infinite options. How about just expanding the last-used/opened repository?

@rcoup rcoup added this to the Initial Release milestone Dec 14, 2021
@volaya
Copy link
Contributor

volaya commented Dec 15, 2021

Yes, that can be a solution. However, to expand the first level ("Repositories"), we already need to make one call for each repo, in order to get the name of the current branch for each repo, to show it along with its name)
Maybe we can change that to not show the current branch (I think it's quite useful), or to show it in a different place, under the repo item, so we do not need to get the current branch name just to show the repo name.

@rcoup rcoup closed this as completed Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants