Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'show feature history' will always show features from a layer even if it isn't currently visible #85

Open
pfw opened this issue Nov 7, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@pfw
Copy link
Contributor

pfw commented Nov 7, 2022

Describe the bug
If there are more than one layers from Kart repos on a map and "Activate 'show feature history' map tool" is selected on a layer which is not the top most feature history from that layer will always be used even if features from other layers are 'in front' of that chosen layer.

Expected behavior
Not sure as the choice was explicit but the end result is at best non obvious, particularly if the layers are from the same 'Author'. Potentially it should highlight the selected feature as per 'select features' QGIS command.

Screenshots

Screenshot 2022-11-07 at 6 16 10 pm

Screenshot 2022-11-07 at 6 20 25 pm

Screenshot 2022-11-07 at 6 23 14 pm

Version info (this is important!):

  • Operating System (e.g. Windows 10, macOS): MacOS
  • QGIS, Kart & Plugin details: QGIS 3.28 Kart plugin 1.0.4
Kart Plugin version
1.0.4
QGIS version
3.28.0-Firenze
Operating system
macOS 13.0 x86_64 i386 64bit
Kart version
Kart v0.11.5, Copyright (c) Kart Contributors
» GDAL v3.4.0; PROJ v6.3.0
» PyGit2 v1.9.0; Libgit2 v1.4.2; Git v2.33.GIT
» SQLAlchemy v1.4.40; pysqlite3 v2.6.0/v3.31.1; SpatiaLite v5.0.1; Libpq v14.0.5
» SpatialIndex v1.9.3
@pfw pfw added the bug Something isn't working label Nov 7, 2022
@rcoup
Copy link
Member

rcoup commented Nov 7, 2022

Expected behavior

At first thought I'd expect it to only work for the selected/active layer, same as editing. Though in your screenshots the selected layer isn't visible, so maybe the functionality should be disabled.

@hamishcampbell opinions?

@pfw
Copy link
Contributor Author

pfw commented Nov 7, 2022

If we can successfully hook into the layer being hidden we could do that, the most odd case is both visible but the one with the select feature on not at the top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants