Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show: Add a way to not show a full diff #721

Closed
craigds opened this issue Oct 19, 2022 · 0 comments
Closed

show: Add a way to not show a full diff #721

craigds opened this issue Oct 19, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@craigds
Copy link
Member

craigds commented Oct 19, 2022

We'd like to be able to get structured details for a commit without producing or parsing megabytes of JSON.

I'd suggest adding a --diff-format option with the following semantics:

kart show -o json --diff-format=none <sha1>:

No diff at all. display commit metadata only (author/message/parent commit/etc)

kart show -o json --diff-format=full <sha1>

Full diff (same as no flag)

kart show -o json --diff-format=no-data-changes <sha1>

Display a diff, but don't include the feature/tile tree for datasets. Replace with a data_changes: true|false boolean to say if the feature/tile tree changed, so the caller knows whether they might need to request the full diff later.

@craigds craigds added the enhancement New feature or request label Oct 19, 2022
@craigds craigds added the good first issue Good for newcomers label Mar 15, 2023
@fedch fedch mentioned this issue Mar 24, 2023
3 tasks
@craigds craigds closed this as completed Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants