import: Fix KeyError in shallow clones #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsen232
reviewed
Apr 8, 2021
sno/fast_import.py
Outdated
| class CommitMissing(Exception): | ||
| pass | ||
|
|
||
| def iter_log(repo): |
There was a problem hiding this comment.
Name is a bit vague - maybe safe_walk_repo or something
olsen232
approved these changes
Apr 8, 2021
In dc2153d I made imports adjust feature comparison behaviour based on whether the repo has previously had a schema change or not. However, this involves walking the repo log, and in shallow clones some commits may be unavailable, causing a KeyError. This commit fixes the KeyError and always does the feature comparison if in a shallow clone where the last schema change commit is not available.
craigds
force-pushed
the
fix-import-in-shallow-clone
branch
from
86715eb
to
3e1e306
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In dc2153d I made imports adjust
feature comparison behaviour based on whether the repo has
previously had a schema change or not.
However, this involves walking the repo log, and in shallow clones
some commits may be unavailable, causing a KeyError.
This commit fixes the KeyError and always does the feature comparison
if in a shallow clone where the last schema change commit is not
available.
Related links:
.
Checklist: