Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] sharePoolCPUCore not exclude LSE #1403

Closed
j4ckstraw opened this issue Jun 21, 2023 · 4 comments · Fixed by #1404
Closed

[BUG] sharePoolCPUCore not exclude LSE #1403

j4ckstraw opened this issue Jun 21, 2023 · 4 comments · Fixed by #1404
Labels
kind/bug Create a report to help us improve

Comments

@j4ckstraw
Copy link
Contributor

j4ckstraw commented Jun 21, 2023 •
edited

What happened:
I found sharePoolCPUCore logic not exclude LSE pod in function getNodeStateForBurst

koordinator/pkg/koordlet/resmanager/cpu_burst.go

Line 234 in 382f7a0

func (b *CPUBurst) getNodeStateForBurst(sharePoolThresholdPercent int64,

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • App version:
  • Kubernetes version (use kubectl version):
  • Install details (e.g. helm install args):
  • Node environment (for koordlet/runtime-proxy issue):
    • Containerd/Docker version:
    • OS version:
    • Kernal version:
    • Cgroup driver: cgroupfs/systemd
  • Others:
@j4ckstraw j4ckstraw added the kind/bug Create a report to help us improve label Jun 21, 2023
@j4ckstraw
Copy link
Contributor Author

how about this?
sharePoolCPUCoresTotal = nodeCPUCoresTotal - LSE - LSR
sharePoolCPUCoresUsage = nodeCPUCoresUsage - LSE - LSR - BE

@j4ckstraw j4ckstraw mentioned this issue Jun 21, 2023
Merged
3 tasks
@j4ckstraw
Copy link
Contributor Author

how about this? sharePoolCPUCoresTotal = nodeCPUCoresTotal - LSE - LSR sharePoolCPUCoresUsage = nodeCPUCoresUsage - LSE - LSR - BE

or this?
sharePoolCPUCoresTotal = nodeCPUCoresTotal - LSE
sharePoolCPUCoresUsage = nodeCPUCoresUsage - LSE - LSR - BE

@saintube
Copy link
Member

how about this? sharePoolCPUCoresTotal = nodeCPUCoresTotal - LSE - LSR sharePoolCPUCoresUsage = nodeCPUCoresUsage - LSE - LSR - BE

This is correct.

@eahydra eahydra linked a pull request Jun 27, 2023 that will close this issue
koordlet: exclude LSE from share cpu pool #1404
Merged
3 tasks
@eahydra
Copy link
Member

eahydra commented Jun 27, 2023

fixed by #1404

@eahydra eahydra closed this as completed Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Create a report to help us improve
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

koordlet: exclude LSE from share cpu pool j4ckstraw/koordinator
3 participants
@eahydra @j4ckstraw @saintube