Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added external data support #38

Merged
merged 1 commit into from Apr 23, 2017
Merged

Conversation

AndrewDessin
Copy link
Contributor

I added in the ability to specify paths to both the model/trained data, and a path to find the current activity, or current X which we are trying to fit.

If a path is not specified, the normal flows continue.

@coveralls
Copy link

coveralls commented Apr 22, 2017

Coverage Status

Coverage decreased (-2.5%) to 88.177% when pulling 6842ae4 on AndrewDessin:master into 30befb0 on kootenpv:master.

@kootenpv
Copy link
Owner

Great! It works fine :) Just wondering: shouldn't learn also have extra arguments?

@AndrewDessin
Copy link
Contributor Author

Yeah, I was a bit indecisive about it. The reason I didn't include external Learn args is because learn takes one location at a time, collects the data for that location, saves it to files, and calls the train_model() method. Instead I created a new train argument.

I assume that the external user will already have collected their data by locations and stored them as files by location. Therefore, I really only need to train the model. So that is why I added a new train argument, instead of adding arguments to learn. Do you agree?

@kootenpv kootenpv merged commit 667eb83 into kootenpv:master Apr 23, 2017
@kootenpv
Copy link
Owner

Yea, that makes a lot of sense. Again, thanks! Nice PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants