Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP library: make OAuthDataStore an interface #11

Open
GoogleCodeExporter opened this issue Sep 11, 2015 · 4 comments
Open

PHP library: make OAuthDataStore an interface #11

GoogleCodeExporter opened this issue Sep 11, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

I think it would be more flexible if OAuthDataStore is an interface instead
of a class.

Original issue reported on code.google.com by dhofs...@gmail.com on 21 Mar 2008 at 8:02

@GoogleCodeExporter
Copy link
Author

Moreover, there's difference in methods of SimpleOAuthDataStore and 
OAuthDataStore: new_access_token vs 
fetch_access_token etc. But I prefer making methods of OAuthDataStore abstract. 
There's even patch for this.

Original comment by atregoub...@gmail.com on 25 Mar 2008 at 9:59

Attachments:

@GoogleCodeExporter
Copy link
Author

making this an interface is an ehancement, i'm not that excited about the idea
though, opening a new bug for fixing all the data store stuff

Original comment by andyster on 15 Jul 2008 at 9:55

  • Changed state: Accepted
  • Added labels: Priority-Low, Type-Enhancement
  • Removed labels: Priority-Medium, Type-Defect

@GoogleCodeExporter
Copy link
Author

Original comment by andyster on 15 Jul 2008 at 10:02

@GoogleCodeExporter
Copy link
Author

Original comment by andyster on 15 Jul 2008 at 11:17

  • Added labels: Lib-PHP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant