Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for wrong separator in entry #7

Closed
wants to merge 4 commits into from
Closed

Fix for wrong separator in entry #7

wants to merge 4 commits into from

Conversation

sergeioff
Copy link

This PR fixes the following problem:
When plugin is executed on Windows environment and entries contain path separator (e.g. entries: ['js/main.js']) it will lead to a mismatch between files and entries, because in entries the separator will be "/' and in files "".

@coveralls
Copy link

coveralls commented Mar 17, 2018

Pull Request Test Coverage Report for Build 44

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.5%) to 97.5%

Totals Coverage Status
Change from base Build 37: -2.5%
Covered Lines: 28
Relevant Lines: 28

💛 - Coveralls

@sergeioff sergeioff closed this Mar 17, 2018
@sergeioff sergeioff reopened this Mar 17, 2018
@der-On
Copy link
Collaborator

der-On commented Mar 19, 2018

I'm not sure if the place to check for this is the correct one. Shouldn't this be handled by the bundle function instead? Also I'm not shure if browserify/watchify should deal with path seperators? Or maybe it is already the case in a later version of browserify?

@sergeioff sergeioff closed this Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants