Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(repository): major server code refactoring #1837

Merged
merged 1 commit into from Mar 20, 2022

Conversation

jkowalski
Copy link
Contributor

This removes big shared lock held for for the duration of each request
and replaces it with trivially short lock to capture the current
state of the server/repository before passing it to handlers.

Handlers are now limited to only accessing a small subset of Server
functionality to be able to better reason about them.

This removes big shared lock held for for the duration of each request
and replaces it with trivially short lock to capture the current
state of the server/repository before passing it to handlers.

Handlers are now limited to only accessing a small subset of Server
functionality to be able to better reason about them.
@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #1837 (63210b4) into master (9054fd0) will increase coverage by 0.00%.
The diff coverage is 72.65%.

@@           Coverage Diff           @@
##           master    #1837   +/-   ##
=======================================
  Coverage   72.73%   72.74%           
=======================================
  Files         394      396    +2     
  Lines       30829    30921   +92     
=======================================
+ Hits        22423    22492   +69     
- Misses       6722     6736   +14     
- Partials     1684     1693    +9     
Impacted Files Coverage Δ
internal/server/api_restore.go 0.00% <0.00%> (ø)
internal/server/api_user.go 0.00% <0.00%> (ø)
snapshot/stats.go 100.00% <ø> (ø)
internal/server/api_mount.go 9.83% <4.00%> (+1.97%) ⬆️
internal/server/server_mount_manager.go 19.51% <19.51%> (ø)
internal/server/api_repo.go 38.32% <49.23%> (-1.24%) ⬇️
internal/server/api_tasks.go 53.57% <58.33%> (ø)
internal/server/api_policies.go 66.34% <60.00%> (ø)
internal/server/api_ui_pref.go 50.00% <62.50%> (ø)
internal/server/api_object_get.go 62.50% <66.66%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9054fd0...63210b4. Read the comment docs.

@jkowalski jkowalski merged commit 9cba4a9 into kopia:master Mar 20, 2022
jkowalski added a commit to jkowalski/kopia that referenced this pull request Mar 21, 2022
This fixes a regression introduced in kopia#1837
jkowalski added a commit that referenced this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant