fix(cli): fixed 'cache set' CLI regression due to kingpin change #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was caused by a default `-1ns` which is no longer supported in latest Kingpin. The effect was that `kopia cache set` without `--max-list-cache-duration` would fail. Unforutnately test was passing that flag so it was missed. This was likely caused by alecthomas/kingpin#329
Codecov Report
@@ Coverage Diff @@
## master #2173 +/- ##
==========================================
+ Coverage 74.55% 74.62% +0.06%
==========================================
Files 425 425
Lines 33029 33030 +1
==========================================
+ Hits 24625 24648 +23
+ Misses 6618 6605 -13
+ Partials 1786 1777 -9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by a default
-1nswhich is no longer supported in latest Kingpin.The effect was that
kopia cache setwithout--max-list-cache-durationwould fail. Unforutnately test was passing that flag so it was missed during the upgrade of dependency.This was likely caused by alecthomas/kingpin#329