Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(general): Fix upgrade portion of robustness test #2337

Merged
merged 8 commits into from Aug 29, 2022

Conversation

chaitalisg
Copy link
Contributor

Moved the upgrade repository function used in the robustness test to snapmeta package. This gets rid of the poison blob error the test hit earlier this month.

The root cause of the error was separate kopia.config used by the restore operation and upgrade operation. With this change, all operations in the test use the same kopia.config.

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #2337 (88ecfec) into master (07ec981) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2337      +/-   ##
==========================================
- Coverage   74.32%   74.23%   -0.09%     
==========================================
  Files         429      434       +5     
  Lines       33519    34087     +568     
==========================================
+ Hits        24914    25306     +392     
- Misses       6760     6925     +165     
- Partials     1845     1856      +11     
Impacted Files Coverage Δ
cli/command_repository_upgrade.go 64.48% <0.00%> (-6.31%) ⬇️
repo/blob/throttling/throttling_semaphore.go 97.05% <0.00%> (-2.95%) ⬇️
snapshot/snapshotfs/repofs.go 79.29% <0.00%> (-1.52%) ⬇️
repo/initialize.go 74.61% <0.00%> (-1.46%) ⬇️
cli/command_repository_status.go 78.94% <0.00%> (-1.44%) ⬇️
internal/server/source_manager.go 80.51% <0.00%> (-0.63%) ⬇️
cli/observability_flags.go 77.16% <0.00%> (-0.62%) ⬇️
repo/open.go 75.08% <0.00%> (ø)
repo/content/info.go 87.50% <0.00%> (ø)
repo/object/objectid.go 88.88% <0.00%> (ø)
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@adowair adowair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, two questions

@adowair adowair self-requested a review August 28, 2022 09:31
@chaitalisg chaitalisg merged commit 0ae4d63 into kopia:master Aug 29, 2022
@chaitalisg chaitalisg deleted the fix-upgrade-robustness-test-error branch August 29, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants