Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(general): resume TestS3Connect() after fixing regression #2380

Merged
merged 1 commit into from Sep 8, 2022

Conversation

adowair
Copy link
Contributor

@adowair adowair commented Sep 7, 2022

Since the fix minio/minio-go#1682 has merged and go-minio dependency was bumped to v7.0.36 in #2378, this reverts commit 7fbf863 from #2246. Resolves #2247.

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #2380 (2439796) into master (94aadc3) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2380      +/-   ##
==========================================
- Coverage   74.43%   74.40%   -0.03%     
==========================================
  Files         436      436              
  Lines       34522    34522              
==========================================
- Hits        25696    25686      -10     
- Misses       6958     6963       +5     
- Partials     1868     1873       +5     
Impacted Files Coverage Δ
cli/command_content_verify.go 75.00% <0.00%> (-6.04%) ⬇️
internal/server/source_manager.go 81.28% <0.00%> (-1.54%) ⬇️
snapshot/snapshotfs/repofs.go 79.29% <0.00%> (-1.52%) ⬇️
repo/content/index/index_v1.go 75.00% <0.00%> (-1.18%) ⬇️
snapshot/snapshotfs/upload.go 84.18% <0.00%> (+0.33%) ⬆️
internal/server/server.go 73.16% <0.00%> (+0.56%) ⬆️
cli/command_index_recover.go 65.44% <0.00%> (+1.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jkowalski jkowalski merged commit 3e5d611 into kopia:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 regression when connecting to non-existing bucket
2 participants