Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): revert electron upgrade from 19.0.8 to 20.0.1 in /app #2423

Merged
merged 1 commit into from Sep 18, 2022

Conversation

jkowalski
Copy link
Contributor

This reverts commit 5fce956.

The app built with 20.0.1 fails to start on at least darwin/arm64, needs to be investigated.

This reverts commit 5fce956.

The app built with 20.0.1 fails to start on at least darwin/arm64,
needs to be investigated.
@jkowalski jkowalski enabled auto-merge (squash) September 18, 2022 22:25
@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Base: 74.38% // Head: 74.42% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (edafb6b) compared to base (827bb70).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2423      +/-   ##
==========================================
+ Coverage   74.38%   74.42%   +0.04%     
==========================================
  Files         442      442              
  Lines       34969    34969              
==========================================
+ Hits        26010    26025      +15     
+ Misses       7059     7049      -10     
+ Partials     1900     1895       -5     
Impacted Files Coverage Δ
internal/providervalidation/providervalidation.go 63.09% <0.00%> (-1.85%) ⬇️
internal/epoch/epoch_manager.go 84.81% <0.00%> (-0.49%) ⬇️
snapshot/snapshotfs/upload.go 85.01% <0.00%> (+1.10%) ⬆️
internal/server/source_manager.go 82.82% <0.00%> (+1.53%) ⬆️
cli/command_content_verify.go 81.03% <0.00%> (+6.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jkowalski jkowalski merged commit 5c04dbc into kopia:master Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant