Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(general): minor followups to #3041 #3141

Merged
merged 3 commits into from Jul 12, 2023

Conversation

julio-lopez
Copy link
Collaborator

@julio-lopez julio-lopez commented Jul 12, 2023

  • explicitly pass username and hostname instead of repo writer
  • nit: name return values

Follow up to #3041

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.03 ⚠️

Comparison is base (851fe6c) 75.41% compared to head (424685c) 75.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3141      +/-   ##
==========================================
- Coverage   75.41%   75.39%   -0.03%     
==========================================
  Files         459      459              
  Lines       36346    36340       -6     
==========================================
- Hits        27409    27397      -12     
- Misses       7025     7030       +5     
- Partials     1912     1913       +1     
Impacted Files Coverage Δ
cli/command_snapshot_create.go 79.35% <80.00%> (-0.36%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@julio-lopez julio-lopez merged commit c017d26 into kopia:master Jul 12, 2023
28 checks passed
@julio-lopez julio-lopez deleted the fix/nits branch July 12, 2023 01:56
@julio-lopez julio-lopez changed the title style(general): minor followups form #3041 style(general): minor followups to #3041 Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant