fix(ci): add test for theme selection #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Encapsulated the creation of a test repository in a function - Added test for changing the byte representation - Added test for changing the pagination
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3157 +/- ##
==========================================
- Coverage 75.39% 75.34% -0.06%
==========================================
Files 459 459
Lines 36340 36408 +68
==========================================
+ Hits 27399 27430 +31
- Misses 7028 7056 +28
- Partials 1913 1922 +9
☔ View full report in Codecov by Sentry. |
|
The test for the pagination settings needs a proper ID for the dropdown menu in html-ui. Will make a pr for this. Cheers, |
added 2 commits
July 20, 2023 20:20
|
this is awesome, thank you! |
jkowalski
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear all,
this PR contains:
The PR is currently a draft. While the test for selecting different themes works, the tests for testing pagination and byte representation still needs to be finished. I was not able to extract the text within the cell, where the size of the snapshot is located.
The idea was to get the size in both byte representations and compare them.
Feedback is welcomed.
Cheers,