New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(providers): split providers test workflow #3158
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3158 +/- ##
==========================================
- Coverage 75.43% 75.38% -0.06%
==========================================
Files 459 459
Lines 36341 36341
==========================================
- Hits 27414 27395 -19
- Misses 7020 7033 +13
- Partials 1907 1913 +6 ☔ View full report in Codecov by Sentry. |
68d0e15
to
96d4501
Compare
name: Provider Test | ||
if: ${{ github.repository == 'kopia/kopia' }} | ||
name: Core Providers Test | ||
if: ${{ github.repository == 'kopia/kopia' && !github.event.pull_request.head.repo.fork }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about ?:
if: ${{ github.event_name == 'schedule' }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to run on various events, including branch and tag pushes, not just PRs.
jobs: | ||
provider-test: | ||
name: Extra Providers Test | ||
if: ${{ github.repository == 'kopia/kopia' && !github.event.pull_request.head.repo.fork }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same suggestion as above:
if: ${{ github.event_name == 'schedule' }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor comment
Split into core and extra providers.
Core providers tests run after merging into the main branch and daily on schedule.
Extra providers tests run twice a week (T, Th).
Both workflows can be triggered on demand as well.
Executions of these workflows: