Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(providers): split providers test workflow #3158

Merged
merged 3 commits into from Jul 19, 2023

Conversation

julio-lopez
Copy link
Collaborator

@julio-lopez julio-lopez commented Jul 18, 2023

Split into core and extra providers.

Core providers tests run after merging into the main branch and daily on schedule.
Extra providers tests run twice a week (T, Th).

Both workflows can be triggered on demand as well.

Executions of these workflows:

@julio-lopez julio-lopez changed the title test(providers): move core providers test to providers-core.yml workflow test(providers): move core providers test to providers-core.yml Jul 18, 2023
@julio-lopez julio-lopez changed the title test(providers): move core providers test to providers-core.yml test(providers): split providers test workflow Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (ffa5b64) 75.43% compared to head (96d4501) 75.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3158      +/-   ##
==========================================
- Coverage   75.43%   75.38%   -0.06%     
==========================================
  Files         459      459              
  Lines       36341    36341              
==========================================
- Hits        27414    27395      -19     
- Misses       7020     7033      +13     
- Partials     1907     1913       +6     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@julio-lopez julio-lopez self-assigned this Jul 19, 2023
@julio-lopez julio-lopez marked this pull request as ready for review July 19, 2023 00:16
@julio-lopez julio-lopez merged commit 78e9aee into kopia:master Jul 19, 2023
31 of 32 checks passed
@julio-lopez julio-lopez deleted the tests/providers-split branch July 19, 2023 00:19
name: Provider Test
if: ${{ github.repository == 'kopia/kopia' }}
name: Core Providers Test
if: ${{ github.repository == 'kopia/kopia' && !github.event.pull_request.head.repo.fork }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about ?:

if: ${{ github.event_name == 'schedule' }}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to run on various events, including branch and tag pushes, not just PRs.

jobs:
provider-test:
name: Extra Providers Test
if: ${{ github.repository == 'kopia/kopia' && !github.event.pull_request.head.repo.fork }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same suggestion as above:

if: ${{ github.event_name == 'schedule' }}

Copy link
Collaborator

@Shrekster Shrekster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants