Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Task summary should show fatal errors #3190

Merged
merged 1 commit into from Aug 3, 2023

Conversation

lupusA
Copy link
Contributor

@lupusA lupusA commented Aug 3, 2023

Hi,

currently, the task summary shows the total number of ignored errors. Since the user is interested in non ignored errors, the summary should show fatal errors (see https://kopia.discourse.group/t/kopiaui-bug-on-log/2171/2)

Fatal errors are already shown when browsing the snapshot (indicated by a warning sign). However, the task summary showed ignored errors causing inconsistencies between both views.

image image

This PR contains the following fix:

  • Store and send the total number of fatal errors

It would also be possible to extend the task summary to show ignored and fatal errors separately.

Feedback is welcomed.

Cheers,

@lupusA lupusA requested a review from julio-lopez August 3, 2023 11:47
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 8.33% and project coverage change: +0.04% 🎉

Comparison is base (a620349) 75.41% compared to head (8760ebe) 75.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3190      +/-   ##
==========================================
+ Coverage   75.41%   75.46%   +0.04%     
==========================================
  Files         459      459              
  Lines       36445    36447       +2     
==========================================
+ Hits        27484    27503      +19     
+ Misses       7043     7033      -10     
+ Partials     1918     1911       -7     
Files Changed Coverage Δ
snapshot/snapshotfs/upload_progress.go 70.10% <8.33%> (-1.48%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julio-lopez julio-lopez merged commit 5663728 into kopia:master Aug 3, 2023
28 of 29 checks passed
@julio-lopez
Copy link
Collaborator

@jkowalski FYI

@lupusA lupusA deleted the fix-task-error-counter branch September 14, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants