fix(general): change cache full logging frequency & message #3193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nutes Addresses concernes about too many messages in the logs (kopia#3085)
Instead log the cache description, which provides information about the types of contents being cached. Followup to kopia#3085 :
|
@arouene FYI |
Shrekster
approved these changes
Aug 3, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3193 +/- ##
==========================================
- Coverage 75.41% 75.39% -0.02%
==========================================
Files 459 459
Lines 36456 36456
==========================================
- Hits 27494 27487 -7
- Misses 7047 7050 +3
- Partials 1915 1919 +4
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followups to #3085
Change cache full logging frequency to once every 10 minutes. Addresses concerns about too many messages in the logs in #3085
Avoid logging cache key. Instead log the cache description, which provides information about the types of contents being cached.