feat(providers): improve performance of SFTP uploads #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the performance of gather writes (p and q blobs) in particular on high-latency links by reducing round-trips. Tested by uploading Kopia working directory (3 GB, files:32157 dirs:6051) to SFTP server on LAN (TrueNAS) over WiFi: Before: 2m4s (~24 MB/s) After: 1m13s (~41 MB/s)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3235 +/- ##
==========================================
+ Coverage 75.38% 75.41% +0.03%
==========================================
Files 459 459
Lines 36498 36506 +8
==========================================
+ Hits 27514 27532 +18
+ Misses 7064 7058 -6
+ Partials 1920 1916 -4
☔ View full report in Codecov by Sentry. |
julio-lopez
reviewed
Aug 21, 2023
| defer contig.Close() | ||
|
|
||
| if _, err := data.WriteTo(contig); err != nil { | ||
| return errors.Wrap(err, "can't write to comtiguous buffer") |
There was a problem hiding this comment.
s/comtiguous/contiguous/
|
@jkowalski I do not understand (yet) where the overhead was coming from or what was causing the slowdown. Could you elaborate? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the performance of gather writes (p and q blobs) in particular on high-latency links by reducing round-trips.
Tested by uploading Kopia working directory
(3 GB, files:32157 dirs:6051) to SFTP server on LAN (TrueNAS) over WiFi:
Before: 2m4s (~24 MB/s)
After: 1m13s (~41 MB/s)