Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Allow specifying whether local or all snapshots are shown by default #3289

Merged
merged 1 commit into from Sep 12, 2023

Conversation

PhracturedBlue
Copy link
Contributor

When I connect to the server http page, I prefer to see all snapshots shown by default. every time I switch away and come back I need to reselect 'All' instead of 'Local'. This just makes the default a preference option.

Requires kopia/htmlui#186

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (741fbd4) 75.67% compared to head (3560137) 75.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3289      +/-   ##
==========================================
- Coverage   75.67%   75.65%   -0.02%     
==========================================
  Files         460      460              
  Lines       36852    36852              
==========================================
- Hits        27888    27882       -6     
- Misses       7036     7040       +4     
- Partials     1928     1930       +2     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PhracturedBlue PhracturedBlue changed the title Allow specifying whether local or all snapshots are shown by default feat(ui): Allow specifying whether local or all snapshots are shown by default Sep 11, 2023
@PhracturedBlue
Copy link
Contributor Author

I noticed that this will result in a configuration setting that has no effect when using the kopiaUI application (since multiUser is false there).

Solutions:

  • keep the code as is
  • leave the setting always available and place it in a 'multi user' section
  • query multi-user mode on the preferences page and hide the config option
  • remove the config option altogether and default to 'All Snapshots' if there is no local snapshot

The last option cold be done entirely in the UI without a need for any server-side changes, but it is the least flexible.

@jkowalski jkowalski merged commit 30d6ef2 into kopia:master Sep 12, 2023
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants