Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deps): migrate from github.com/Azure/azure-storage-blob-go to github.com/Azure/azure-sdk-for-go/sdk/storage/azblob #3760

Merged
merged 2 commits into from Apr 2, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Apr 1, 2024

This replace the deprecated dependency github.com/Azure/azure-storage-blob-go with the recommended version github.com/Azure/azure-sdk-for-go/sdk/storage/azblob

Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com

@mmorel-35 mmorel-35 changed the title Migrate from github.com/Azure/azure-storage-blob-go to github.com/Azure/azure-sdk-for-go/sdk/storage/azblob build(deps): migrate from github.com/Azure/azure-storage-blob-go to github.com/Azure/azure-sdk-for-go/sdk/storage/azblob Apr 1, 2024
@mmorel-35 mmorel-35 changed the title build(deps): migrate from github.com/Azure/azure-storage-blob-go to github.com/Azure/azure-sdk-for-go/sdk/storage/azblob build(deps): migrate from github.com/Azure/azure-storage-blob-go to github.com/Azure/azure-sdk-for-go/sdk/storage/azblob Apr 1, 2024
@mmorel-35 mmorel-35 changed the title build(deps): migrate from github.com/Azure/azure-storage-blob-go to github.com/Azure/azure-sdk-for-go/sdk/storage/azblob refactor(deps): migrate from github.com/Azure/azure-storage-blob-go to github.com/Azure/azure-sdk-for-go/sdk/storage/azblob Apr 1, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.89%. Comparing base (cb455c6) to head (c6fe5ad).
Report is 81 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3760      +/-   ##
==========================================
+ Coverage   75.86%   76.89%   +1.02%     
==========================================
  Files         470      476       +6     
  Lines       37301    28930    -8371     
==========================================
- Hits        28299    22246    -6053     
+ Misses       7071     4740    -2331     
- Partials     1931     1944      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 force-pushed the azure-storage-blob-go branch 3 times, most recently from a7a63b9 to bb0ddc2 Compare April 2, 2024 04:48
@julio-lopez
Copy link
Collaborator

@mmorel-35 Instead of force-pushing updates to the PR in a single commit, can you push separate commits with only the additional changes please? It facilitates reviews. Thank you.

@julio-lopez
Copy link
Collaborator

julio-lopez commented Apr 2, 2024

@mmorel-35 There are a few lint errors, PTAL.
You can run make lint locally before pushing to the branch for this PR.
Also, compilation is failing in some cases.

@mmorel-35 mmorel-35 marked this pull request as draft April 2, 2024 05:11
…o github.com/Azure/azure-sdk-for-go/sdk/storage/azblob

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Copy link
Contributor Author

I had to rebase to handle conflicts on go.mod and go.sum.

This shall be ready to review.

@mmorel-35 mmorel-35 marked this pull request as ready for review April 2, 2024 05:22
@julio-lopez julio-lopez merged commit 5120313 into kopia:master Apr 2, 2024
23 checks passed
@julio-lopez
Copy link
Collaborator

@mmorel-35 Thanks for your contribution

@mmorel-35 mmorel-35 deleted the azure-storage-blob-go branch April 2, 2024 05:54
@julio-lopez
Copy link
Collaborator

@mmorel-35 This change is failing in the following test. PTAL

https://github.com/kopia/kopia/actions/runs/8518078600/job/23329613384

@julio-lopez
Copy link
Collaborator

@KastenMike FYI

julio-lopez added a commit that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants