refactor(general): include parameters in pbkdf2 instantiation #3811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3811 +/- ##
==========================================
+ Coverage 75.86% 77.06% +1.19%
==========================================
Files 470 473 +3
Lines 37301 28656 -8645
==========================================
- Hits 28299 22083 -6216
+ Misses 7071 4684 -2387
+ Partials 1931 1889 -42 ☔ View full report in Codecov by Sentry. |
|
FYI: @bathina2 @miquella @kidgilson |
kidgilson
reviewed
Apr 19, 2024
julio-lopez
force-pushed
the
pbkdf-instance-name
branch
from
129586e
to
d2945a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
pbkdf2-sha256-600000as the name to be consistent with the scrypt instantiation.The format is
pbkdf2-<hash_type>-<number_of_iterations>