refactor(general): user password hashing and key derivation helpers #3821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3821 +/- ##
==========================================
+ Coverage 75.86% 77.01% +1.15%
==========================================
Files 470 476 +6
Lines 37301 28682 -8619
==========================================
- Hits 28299 22090 -6209
+ Misses 7071 4694 -2377
+ Partials 1931 1898 -33 ☔ View full report in Codecov by Sentry. |
julio-lopez
changed the title
The variable is used in all the implementations of password hashing, not just V1. No functional changes.
The constant is located in the `internal/user` package, this de-couples it from the value in the `crypto` package. This introduces no functional changes.
Objective: remove dependency on `crypto.RecommendedSaltLength()`, with the intent of removing that function and other helpers in the crypto package. No functional change
Adds:
- user.DefaultPasswordHashingAlgorithm constant
- user.PasswordHashingAlgorithms helper
Uses these to set up the CLI for the 'repo server user {add,set}' commands.
Also, removes dependent functions. No functional change.
No functional changes
Also, reorders constant definition order. No functional changes.
No functional change.
…reate flag definition
No longer used outside the package => unexported Renamed to supportedPBKeyDerivationAlgorithms No functional changes
Adds a common prefix `pb_key_deriver_` No functional changes.
It contains the user password hashing implementation for all the password hashing schemes currently supported in kopia.
julio-lopez
force-pushed
the
test/user-profile-hashing
branch
from
24a6dfb
to
31259db
Compare
julio-lopez
commented
Apr 27, 2024
| // keys" for the register password-based key derivers in the crypto package. | ||
| // This trivial test is a change detector to ensure that the constants defined | ||
| // in the user package match those defined in the crypto package. | ||
| func TestPasswordHashingConstantMatchCryptoPackage(t *testing.T) { |
There was a problem hiding this comment.
@bathina2 This is what I meant by "adding a test to ensure the constants match".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code movement and simplification, no functional changes.
Objectives:
Changes:
crypto.DeriveKeyFromPasswordnow takes a key size.crypto.MasterKeySizeconst.crypto.DefaultKeyDerivationAlgorithmconst.Followups to:
The individual commits show the code transformations to simplify the review of the changes.