Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(general): make key derivers available in tests #3826

Merged
merged 7 commits into from
May 1, 2024

Conversation

julio-lopez
Copy link
Collaborator

@julio-lopez julio-lopez commented Apr 27, 2024

  • Re-introduces the insecure, lightweight key deriver for testing only.
  • Makes scrypt and pbkdf2 derivers available in tests as well.

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 77.05%. Comparing base (cb455c6) to head (dc61b78).
Report is 120 commits behind head on master.

Files Patch % Lines
internal/crypto/pb_key_deriver_insecure_testing.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3826      +/-   ##
==========================================
+ Coverage   75.86%   77.05%   +1.18%     
==========================================
  Files         470      479       +9     
  Lines       37301    28714    -8587     
==========================================
- Hits        28299    22125    -6174     
+ Misses       7071     4693    -2378     
+ Partials     1931     1896      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julio-lopez julio-lopez force-pushed the cleanup/pbkd-insecure-testing branch from e5f174b to 466130f Compare April 27, 2024 05:53
@julio-lopez julio-lopez force-pushed the cleanup/pbkd-insecure-testing branch from 466130f to d42c950 Compare April 27, 2024 06:40
@julio-lopez julio-lopez force-pushed the cleanup/pbkd-insecure-testing branch from d42c950 to dc61b78 Compare April 27, 2024 06:49
@julio-lopez julio-lopez marked this pull request as ready for review April 27, 2024 16:33
@julio-lopez julio-lopez enabled auto-merge (squash) April 27, 2024 16:33
@julio-lopez julio-lopez disabled auto-merge May 1, 2024 00:20
@julio-lopez julio-lopez merged commit 065e0ad into kopia:master May 1, 2024
28 checks passed
@julio-lopez julio-lopez deleted the cleanup/pbkd-insecure-testing branch May 1, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant