fix(cli): Fix client IPv6 URI generation for gRPC connections #3830
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connecting to gRPC repository API using an IPv6 address does not correctly configure the URI for the client's dial. Reconstructing the parsed URL into
hostname + ":" + port
will remove the square brackets required for IPv6 addressing, resulting in atoo many colons in address
error.Fix the issue by instead using the helper
net.JoinHostPort()
, which will add square brackets for IPv6 hostnames.Tested by running
TestServer
withhttptest.serve
flag set, forcing the test server to listen on the IPv6 loopback:Fails without fix:
Passes with fix: