Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(general): remove ability to enable compaction on index load #3834

Merged
merged 4 commits into from
May 1, 2024
Merged

refactor(general): remove ability to enable compaction on index load #3834

merged 4 commits into from
May 1, 2024

Conversation

julio-lopez
Copy link
Collaborator

@julio-lopez julio-lopez commented May 1, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented May 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.13%. Comparing base (cb455c6) to head (85bcc25).
Report is 124 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3834      +/-   ##
==========================================
+ Coverage   75.86%   77.13%   +1.26%     
==========================================
  Files         470      479       +9     
  Lines       37301    28670    -8631     
==========================================
- Hits        28299    22114    -6185     
+ Misses       7071     4657    -2414     
+ Partials     1931     1899      -32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julio-lopez julio-lopez marked this pull request as ready for review May 1, 2024 02:07
@julio-lopez julio-lopez requested a review from jkowalski May 1, 2024 02:08
@julio-lopez julio-lopez enabled auto-merge (squash) May 1, 2024 20:47
redgoat650
redgoat650 approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@redgoat650 redgoat650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julio-lopez julio-lopez disabled auto-merge May 1, 2024 21:33
@julio-lopez julio-lopez merged commit ad06bb2 into kopia:master May 1, 2024
30 checks passed
@julio-lopez julio-lopez deleted the cleanup/index-compaction-read branch May 1, 2024 21:33
Lyndon-Li pushed a commit to Lyndon-Li/kopia that referenced this pull request Jun 3, 2024
@julio-lopez @Lyndon-Li
refactor(general): remove ability to enable compaction on index load (k…
419c535 
…opia#3834)

Cleanup.

- Fixes: kopia#3638
- kopia#3639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redgoat650 redgoat650 redgoat650 approved these changes

@plar plar Awaiting requested review from plar

@Shrekster Shrekster Awaiting requested review from Shrekster

@jkowalski jkowalski Awaiting requested review from jkowalski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid index (epoch) cleanup and compaction during index reads
2 participants
@julio-lopez @redgoat650