Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): cache hard limits flags #3846

Merged
merged 2 commits into from
May 7, 2024
Merged

Conversation

DarkArc
Copy link
Contributor

@DarkArc DarkArc commented May 6, 2024

No description provided.

Add reference to the cache hard limits.
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.15%. Comparing base (cb455c6) to head (e6181fe).
Report is 132 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3846      +/-   ##
==========================================
+ Coverage   75.86%   77.15%   +1.28%     
==========================================
  Files         470      479       +9     
  Lines       37301    28674    -8627     
==========================================
- Hits        28299    22122    -6177     
+ Misses       7071     4657    -2414     
+ Partials     1931     1895      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julio-lopez julio-lopez changed the title [Documentation] Add a nod to the hard limits flags for caching docs(cli): cache hard limits flags May 7, 2024
@julio-lopez julio-lopez merged commit e5790e3 into kopia:master May 7, 2024
23 of 24 checks passed
@julio-lopez julio-lopez requested a review from Shrekster May 7, 2024 19:02
@@ -57,6 +57,14 @@ $ kopia cache set --max-list-cache-duration=300s
Note the cache sizes are not hard limits: cache is swept periodically (every few minutes) to bring
the total usage below the defined limit by removing least-recently used cache items.

A hard limit can be set if required via the corresponding `limit` flag:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a side-note or a warning to this message that this setting hard limits can potentially increase the network activity ?

Copy link
Contributor Author

@DarkArc DarkArc May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That feels implied that if you have less of a cache you might have to fetch things more often.

Edit: if you've got details/a deeper insight into the impact though ... please by all means. I'm not a Kopia author, just trying to improve the documentation a bit as I learn things.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem, we can watch for community usage and add this note later if need be. Thank you for your contribution!

I understand your point about this being obvious to users, so the smaller the limit the greater the network utilization expectation. I raised the concern because the impact has been perceived to be significant in some case. For example this issue:

#3059

We fixed the above problem BTW by allowing separate cache limits and defaults for each type of cache (list, index, metadata & content). I don't have the data yet, but I think playing with all of these limits can surface some interesting network behavior.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... That's definitely interesting, thanks for sharing. That does seem excessive.

This comment in particular:

But for now you really need to allocate a big cache, our is 300GB (260GB for metadata, 40GB for data), for 300 snapshots of about 10GB each.

That seems like a strikingly large caching requirement.

@DarkArc DarkArc deleted the patch-1 branch May 7, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants