Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting keywords in metadata view #34

Closed
margaretha opened this issue Mar 6, 2018 · 6 comments
Closed

Formatting keywords in metadata view #34

margaretha opened this issue Mar 6, 2018 · 6 comments
Assignees

Comments

@margaretha
Copy link
Contributor

The value of foundries field should be listed in a more readable way.

Example of foundries value
corenlp corenlp/constituency corenlp/morpho corenlp/sentences dereko dereko/structure dereko/structure/base-sentences-paragraphs-pagebreaks malt malt/dependency opennlp opennlp/morpho opennlp/sentences

@margaretha margaretha added this to the Methodenmesse-2018 milestone Mar 6, 2018
@Akron
Copy link
Member

Akron commented Mar 6, 2018

What would you suggest for formatting? I think, keywords (this includes the field "foundries") should in the future be shown as list, but currently we don't have this information in the index, I think (in the index there is no difference between text and keywords for the moment, if I remember correctly).

@Akron
Copy link
Member

Akron commented Mar 6, 2018

I improved Krill to mark keywords as keywords in the index. Unfortunately this requires reindexing, so I would skip this feature to after the Methodenmesse.

@margaretha
Copy link
Contributor Author

ok. thanks

@Akron
Copy link
Member

Akron commented Mar 8, 2018

As this still requires an implementation on the side of Kalamar, I reopen the issue.

@Akron Akron reopened this Mar 8, 2018
@Akron Akron removed this from the Methodenmesse-2018 milestone Mar 8, 2018
@Akron Akron changed the title Formatting foundries Formatting keywords in metadata view Mar 8, 2018
@Akron
Copy link
Member

Akron commented Mar 8, 2018

The list should be formatted similar to the multi-value-lists in the token annotation view, see https://github.com/KorAP/Kalamar/blob/master/dev/js/src/match/table.js#L184-L197 . Therefore each keyword can be chosen separately in the corpusByMatch assistant #27 .

idsgerrit pushed a commit that referenced this issue Apr 23, 2018
Change-Id: I69cc32e74414a82ea8ac1883441fcdf181569c4d
@Akron
Copy link
Member

Akron commented Apr 23, 2018

Implemented in 24fbc9e - thanks!

@Akron Akron closed this as completed Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants