Inferior crashes after a certain time once in a while upon injection of a never-ending thread

[korcankaraokcu]

It also crashes when superfluous number of threads get injected, which is quite normal to be honest but not desirable. Will try to write better threads asap.

[salihmarangoz]

In PINCE/Injection/AdditionalThreadInjection.c",

threadinf is a local variable, it deallocates from memory when function ends. This may cause problems because first parameter of pthread_create() is the address of threadinf.

Suggested Change:

void injection()
{
    int *a=1;
    pthread_t *threadinf = (pthread_t*) malloc (sizeof(pthread_t));
    pthread_create(threadinf, NULL, infinite, (void*) a);
}

[korcankaraokcu]

That was a good one, tested on a few applications. After this patch, the debuggee doesn't crash even after 20-25 thread injections. Might close this issue once I test this enough.

Edit: Done enough tests, this is the correct fix. Thank you again @salihmarangoz. Closing this issue.

Closed by this patch