Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaFX 12 - FontAwesome5 11.2.0 #48

Closed
dsubelman opened this issue Apr 8, 2019 · 10 comments · Fixed by #50
Closed

JavaFX 12 - FontAwesome5 11.2.0 #48

dsubelman opened this issue Apr 8, 2019 · 10 comments · Fixed by #50

Comments

@dsubelman
Copy link

FontAwesome5 pack v11.2.0 isn't working with JavaFX 12.

@aalmiray
Copy link
Collaborator

aalmiray commented Apr 9, 2019

Do you have an stacktrace that shows the problem? What environment do you have? Which build tool and version are you using?

@dsubelman
Copy link
Author

Thanks for your rapid response.

The issue isn't an error, so there's no stacktrace. The problem is that the icons are not showing (an empty vertical rectangle is shown instead). The issue is with that specific pack only, all other packs work perfectly.

OS: Windows 10 Pro v1809
Environment: JDK 11.0.2
Build tool: Maven (Apache Maven Compiler Plugin v3.8.0, Exec Maven Plugin v1.6.0)

Let me know if you need more information.

@aalmiray
Copy link
Collaborator

I see it now. It looks like Ionicons4 also has trouble rendering some icons.

@aalmiray
Copy link
Collaborator

Fixed and released in 11.3.0.

@dsubelman
Copy link
Author

Thanks again! That was incredibly fast!!!

@dsubelman
Copy link
Author

dsubelman commented Apr 11, 2019

I implemented version 11.3.0 but the problem persists.

Also, when adding v11.3.0 from Maven to Scene Builder v11 the FontIcon component can't be imported (FontIconTable Cell and StackedFontIcon are ok).

Ikonli v11 3 0 SceneBuilder v11

Should I open a new issue?

@aalmiray
Copy link
Collaborator

I'm confused now. The report is against JavaFX 12, but the build environment uses JDK 11.0.2.
I'm assuming the problem is on the latest SceneBuilder 11, is that correct?

@dsubelman
Copy link
Author

Correct and correct!
The issue is against JavaFX12 and the build environment uses JDK 11.0.2.
The problem is on the latest SceneBuilder 11.

@aalmiray
Copy link
Collaborator

This is strange indeed. Just downloaded the latest SceneBuilder 11 on OSX and I get the following when loading Ikonli JARs using the JAR Manager
sb-1
sb-2

@dsubelman
Copy link
Author

From your images I can see my mistake...
I didn't import "ikonli-core" into Scene Builder (only "ikonli-javafx"). Importing "ikonli-core" solves the problem.

Does FontAwesome5 work on JavaFX 12 using v11.3.0 in your environment? I haven't been able to make it work.

I think I'll have some time tomorrow to take a look into ikonli's code and see if I can find the issue. Let you know if I get lucky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants