Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): bootstrap domain features with organization domain #214

Merged
merged 32 commits into from
Jul 16, 2023
Merged

feat(api): bootstrap domain features with organization domain #214

merged 32 commits into from
Jul 16, 2023

Conversation

timonmasberg
Copy link
Member

@timonmasberg timonmasberg commented May 30, 2023 •
edited
Loading

This PR introduces the Organization domain with the following changes to the overall application:

  • added validation pipeline to validate incoming arguments for GraphQL
  • added a logger to the observability module that logs to the console and in production environments also to sentry
  • added a base entity model that contains validation logic and some helper interfaces
  • added domain exceptions and presentable exceptions that will be populated over the GraphQL api
  • added overall architecture document that briefly introduces how and why we use the clean architecture approach
  • added organization query and organization geo settings update mutation as first features to discuss and bootstrap our architecture implementation
  • dependency cleanup

@timonmasberg timonmasberg marked this pull request as ready for review June 4, 2023 12:52
@timonmasberg timonmasberg self-assigned this Jun 4, 2023
@timonmasberg timonmasberg requested a review from JSPRH June 4, 2023 13:25
JSPRH
JSPRH reviewed Jun 5, 2023
View reviewed changes
docs/architecture.md Outdated Show resolved Hide resolved
@timonmasberg timonmasberg requested a review from JSPRH June 14, 2023 10:16
@timonmasberg timonmasberg changed the title feat(api): bootstrap architecture with organization feature feat(api): bootstrap domain features with organization domain Jun 14, 2023
@timonmasberg
Merge remote-tracking branch 'origin/main' into feat/organizations
f39e174 
# Conflicts:
#	package-lock.json
#	package.json
@timonmasberg
Merge remote-tracking branch 'origin/main' into feat/organizations
bf0b8a1 
# Conflicts:
#	apps/api/tsconfig.app.json
#	libs/api/observability/tsconfig.lib.json
#	package-lock.json
#	package.json
JSPRH
JSPRH reviewed Jul 15, 2023
View reviewed changes
Copy link
Contributor

@JSPRH JSPRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, looks wonderful! Just some nits

JSPRH
JSPRH previously approved these changes Jul 16, 2023
View reviewed changes
@timonmasberg
Merge remote-tracking branch 'origin/main' into feat/organizations
1344a75 
# Conflicts:
#	package-lock.json
#	package.json
@timonmasberg timonmasberg enabled auto-merge (squash) July 16, 2023 10:22
@sonarcloud
Copy link

sonarcloud bot commented Jul 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.3% 89.3% Coverage
0.0% 0.0% Duplication

@timonmasberg timonmasberg merged commit 2379854 into main Jul 16, 2023
9 checks passed
@timonmasberg timonmasberg deleted the feat/organizations branch July 16, 2023 10:29
@timonmasberg
Copy link
Member Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSPRH JSPRH JSPRH left review comments

Assignees

@timonmasberg timonmasberg

Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timonmasberg @JSPRH