Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct commit sha in pr deployments #330

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

timonmasberg
Copy link
Member

Description

github.sha references the main branch, while we have to reference the actual branch from the PR in our preview deployments.

Fixes #329

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions github-actions bot deleted a comment from timonmasberg Aug 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

Deployment Preview

🏁 This PR has been closed. No deployment preview is available.

@timonmasberg timonmasberg marked this pull request as ready for review August 10, 2023 13:25
@timonmasberg timonmasberg merged commit 489c8af into main Aug 10, 2023
9 checks passed
@timonmasberg timonmasberg deleted the fix/pr-deployment-commit-sha branch August 10, 2023 13:28
@timonmasberg
Copy link
Member Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

/deploy-preview deploys with wrong github.sha
2 participants