fix(api-observability): log unhandled exceptions caught in exceptions… #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSPRH
reviewed
Feb 1, 2024
| name: exception.name, | ||
| stack: exception.stack, | ||
| }, | ||
| this.logger.error(exception.message, undefined, { |
There was a problem hiding this comment.
Suggested change
| this.logger.error(exception.message, undefined, { | |
| this.logger.info(exception.message, undefined, { |
Shouldn't this be .info to log for debug purpose and not as error?
There was a problem hiding this comment.
changed to log type info: 353eee9
|
JSPRH
approved these changes
Feb 1, 2024
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… filter
Description
Also logging unhandled exceptions caught in the exceptions filter to the console by using the logger service.
Checklist:
the Conventional Commits specification.
Coverage > 80% and not less than the current coverage of the main branch.
maininto your feature branch, make sure you have run the latest NX migrations (nx migrate --run-migrations).