Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require cycle on comment nodes #3

Open
mariot opened this issue Aug 3, 2020 · 1 comment
Open

Require cycle on comment nodes #3

mariot opened this issue Aug 3, 2020 · 1 comment

Comments

@mariot
Copy link

mariot commented Aug 3, 2020

Require cycle: src\components\CommentNodes.tsx -> src\components\CommentNode.tsx -> src\components\CommentNodes.tsx

Require cycles are allowed, but can result in uninitialized values. Consider refactoring to remove the need for a cycle.

@koredefashokun
Copy link
Owner

Thanks for running the project locally! Unfortunately, as far as I know, this is a warning, and it's the only way we can get this working, since we have to recursively import the CommentNodes component for every CommentNode and vice-versa. You can take a look at the source code for Lemmy's web frontend here. This project tries to match that implementation as closely as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants