Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTS-1 mkII: The velocity value is always zero #105

Closed
boochow opened this issue Apr 27, 2024 · 3 comments
Closed

NTS-1 mkII: The velocity value is always zero #105

boochow opened this issue Apr 27, 2024 · 3 comments

Comments

@boochow
Copy link
Contributor

boochow commented Apr 27, 2024

When __unit_callback void unit_note_on(uint8_t note, uint8_t velocity) is called, velocity is always zero.
I tested with a MIDI keyboard, and the EG responded to velocity inputs, but the OSC didn't.

While this is not a serious problem, I think it would be useful to use the velocity values as an OSC's modulation source.

@john-k-walton
Copy link

john-k-walton commented Apr 27, 2024

good catch Boochow.

personally, velocity is important for user oscillators. I have used a Yorick LFE to remap velocity to Shape/Shift-Shape CC's. it is very important to me for articulation of user oscillators, after-touch would be helpful at this point as well.

@boochow
Copy link
Contributor Author

boochow commented Jun 14, 2024

I tested this para_saw oscillator and can confirm that firmware v1.2 has fixed this issue.
https://korginc.github.io/logue-sdk/ja/unit-index/korg_examples/

@boochow boochow closed this as completed Jun 14, 2024
@boochow
Copy link
Contributor Author

boochow commented Jun 14, 2024

Note: I slightly modified the code to see if the velocity values are actually available.
sig += voice[i].velo > 96 ? osc_sqrf(phase) : osc_sawf(phase);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants