Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Digest Signing over to sha256 from md5 #128

Closed
RocketJas opened this issue May 1, 2024 · 2 comments
Closed

Switch Digest Signing over to sha256 from md5 #128

RocketJas opened this issue May 1, 2024 · 2 comments

Comments

@RocketJas
Copy link

As the MD5 hash function is considered cryptographically broken, I have switched over the signing to use sha256. I have made this change to a fork and I was wondering if this was appropriate to upstream. RocketJas#1

@kornelski
Copy link
Owner

Thanks for the suggestion. I've implemented it without OpenSSL, which is a heavy dependency.

@RocketJas
Copy link
Author

Thank you for fixing this so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants