Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Switch torch asserts #107

Closed
edgarriba opened this issue Apr 3, 2019 · 2 comments
Closed

[FEAT] Switch torch asserts #107

edgarriba opened this issue Apr 3, 2019 · 2 comments
Labels
good first issue Good for newcomers

Comments

@edgarriba
Copy link
Member

We currently have custom assertion to check equal torch tensors

import utils # test utilities
assert utils.check_equal_torch(trans_02_hat, trans_02)

this can be replaced by:

from torch.testing import  assert_allclose
assert_allclose(rans_02_hat, trans_02)
@edgarriba edgarriba added the good first issue Good for newcomers label Apr 3, 2019
@rsdel2007
Copy link

Do we have to replace from all the places where it is used?

@rsdel2007 rsdel2007 mentioned this issue Apr 21, 2019
Closed
@edgarriba
Copy link
Member Author

closing this since in the last commits this has been incrementally fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edgarriba @rsdel2007