Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible bug in Homography #21

Closed
Mona77 opened this issue Oct 14, 2018 · 2 comments
Closed

possible bug in Homography #21

Mona77 opened this issue Oct 14, 2018 · 2 comments

Comments

@Mona77
Copy link
Contributor

Mona77 commented Oct 14, 2018

@edgarriba To calculate homography matrix you have solved for Ah=x0 where h is [8x1] vector and then you append 1 to this vector.
I would try solving for Ah=0 where h is [9x1] then divide each element of h by the last one. Something similar to opencv

Please let me know if it works.

@edgarriba
Copy link
Member

@Mona77 this is because to transform points with the homography we need homogeneous coordinates (3x3 * 3x1). If you want you can check the maths from this tensorflow implementation:
http://kindoblue.nl/neural-network/tensorflow-homography.

I've also been comparing to OpenCV results and I get the same results.

@bhack
Copy link
Contributor

bhack commented Oct 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants