Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the deprecated decorator in depth_to_3d #2560

Closed
edgarriba opened this issue Sep 22, 2023 · 2 comments · Fixed by #2636
Closed

Add the deprecated decorator in depth_to_3d #2560

edgarriba opened this issue Sep 22, 2023 · 2 comments · Fixed by #2636
Labels
code heatlh 💊 Improvement the package code health help wanted Extra attention is needed
Milestone
kornia v0.7.2

Comments

@edgarriba
Copy link
Member 

          we should add the deprecated decorator there: https://github.com/kornia/kornia/blob/a212b4d0746b15a4e56a34e72ddee9b320284fb9/kornia/utils/helpers.py#L70

Originally posted by @johnnv1 in #2557 (comment)
@edgarriba edgarriba added the code heatlh 💊 Improvement the package code health label Sep 22, 2023
@edgarriba edgarriba added this to the kornia-1-0-alpha milestone Sep 22, 2023
@edgarriba edgarriba added the help wanted Extra attention is needed label Sep 22, 2023
@karakumm
Copy link
Contributor

karakumm commented Oct 6, 2023

can I resolve it? :) @edgarriba

@johnnv1
Copy link
Member

johnnv1 commented Oct 6, 2023

can I resolve it? :) @edgarriba

of course, place a PR for it 😄

@karakumm karakumm mentioned this issue Oct 6, 2023
Closed
4 tasks
@johnnv1 johnnv1 mentioned this issue Oct 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code heatlh 💊 Improvement the package code health help wanted Extra attention is needed
Projects
None yet
Milestone
kornia v0.7.2
Development

Successfully merging a pull request may close this issue.

add deprecated decorator depth_to_3d johnnv1/kornia
Deprecated decorator added karakumm/kornia
3 participants
@edgarriba @johnnv1 @karakumm